{{ message }}
HTML escape included mermaid files to handle embedded tags#1580
Open
mgranell wants to merge 4 commits into
Open
HTML escape included mermaid files to handle embedded tags#1580mgranell wants to merge 4 commits into
mgranell wants to merge 4 commits into
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c539b25:
|
Author
|
Test failed due to timeout, not related to change |
Member
|
Hi, @mgranell |
trusktr
requested changes
Aug 2, 2021
Member
There was a problem hiding this comment.
Maybe we should use a more robust solution like described in the following SO question so that it accounts for other characters, not just those specific ones?
https://stackoverflow.com/questions/18749591/encode-html-entities-in-javascript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where included mermaid files that had embedded tags failed to render, due to the file being included verbatim into the
<div>tag, and embedded html within the mermaid file "breaking out" of the div.e.g. the following mermaid file will fail:
What kind of change does this PR introduce?
Bugfix
For any code change,
There are no tests that test in the include functionality
Does this PR introduce a breaking change? (check one)
Related issue, if any:
Tested in the following browsers: