{{ message }}
chore: Remove the src directory from packages.json's files#1344
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f40c1c4:
|
anikethsaha
approved these changes
Aug 20, 2020
anikethsaha
requested review from
Koooooo-7,
QingWei-Li,
jhildenbiddle and
trusktr
QingWei-Li
approved these changes
Aug 20, 2020
trusktr
reviewed
Aug 21, 2020
trusktr
left a comment
trusktr
left a comment
Member
There was a problem hiding this comment.
This is a breaking change. We should not remove src. Someone may depend on it. Why did you remove it?
Member
|
@QingWei-Li Hello! We've been trying to save breaking changes for v5, but first we're stabilizing the code with tests (see Playwright PR, and some new files like In my opinion, src files should always be published. This allows people to integrate source files into their own build systems which may be preferable over consuming built files (something I do quite often). |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close #1343
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.