{{ message }}
Change onlyCover to true, added option to show menu#1280
Closed
kirbyfern wants to merge 1 commit into
Closed
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0d6aad4: |
sy-records
requested changes
Jul 8, 2020
sy-records
left a comment
sy-records
left a comment
Member
There was a problem hiding this comment.
You need to implement the function of this configuration item instead of just adding a configuration.
anikethsaha
requested changes
Jul 16, 2020
anikethsaha
left a comment
anikethsaha
left a comment
Member
There was a problem hiding this comment.
Please implement the function for this options, add test cases, and also update the docs.
thanks
Koooooo-7
reviewed
Sep 18, 2020
Koooooo-7
left a comment
Koooooo-7
left a comment
Member
There was a problem hiding this comment.
When you complete the implementation of this PR, you can reopen it.
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
When resolving a specific issue, it's referenced in the PR's title (e.g.
fix #xxx[,#xxx], where "xxx" is the issue number)this pr fixes when onlyCover is true, also provide an option to show the menu. #1249 and There is an error in opening the mobile page of the onlyCover parameter #1173
You have tested in the following browsers: (Providing a detailed version will be better.)
Chrome
Firefox
Safari
Edge
IE
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
libdirectory.