{{ message }}
Fix Vue Reactivity#1271
Merged
Merged
Conversation
- Fix inability to instantiate reactive Vue components by 1) handling each child of #main instead of #main itself and 2) skipping elements that are already Vue instances - Retain previous behavior of processing basic Vue rendering without the need for a markdown <script> tag. - Update documentation and add live Vue examples - Update `index.html` files to include Vue.js and Vuep (CSS+JS)
# Conflicts: # docs/index.html
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4f6148d:
|
jhildenbiddle
commented
Jul 5, 2020
anikethsaha
previously approved these changes
Jul 5, 2020
sy-records
previously approved these changes
Jul 5, 2020
trusktr
previously requested changes
Jul 5, 2020
trusktr
left a comment
trusktr
left a comment
Member
There was a problem hiding this comment.
This is a good change, but let's add unit tests.
Member
trusktr
reviewed
Jul 5, 2020
trusktr
reviewed
Jul 5, 2020
1 task
1 task
- When Vue.js is detected, markdown `<script>` is not executed when executeScript is `false` (matches previous behavior) - Minor code tweaks that do not affect functonality
jhildenbiddle
dismissed stale reviews from sy-records, anikethsaha, and Koooooo-7
via
105fbbf
18 tasks
anikethsaha
previously approved these changes
Oct 7, 2020
This was referenced Oct 7, 2020
Closed
anikethsaha
approved these changes
Oct 8, 2020
sy-records
approved these changes
Oct 8, 2020
This was
linked to
issues
Oct 8, 2020
Closed
This was referenced Oct 8, 2020
Closed
This was referenced Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #788 #790 #1074 #1252 #1364
#maininstead of#mainitself and 2) skipping elements that are already Vue instances<script>tag.index.htmlfiles to include Vue.jsCypressJest+Playwright e2e testsSummary: Docsify was mounting
#mainas a Vue component on every page change when it detected Vue.js, presumably to process basic Vue content without requiring a<script>tag in each markdown file. The issue is that this was happening after users had already instantiated child elements of#mainas Vue components, destroying those instances.