{{ message }}
fix #932 - Add embed gist instructions to Embed Files#1238
Merged
anikethsaha merged 6 commits intoJun 22, 2020
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d3a049d:
|
Contributor
Author
|
I'll check the live preview tomorrow - I am having internet issues today. |
sy-records
previously approved these changes
Jun 22, 2020
anikethsaha
requested review from
Koooooo-7,
anikethsaha,
jhildenbiddle and
trusktr
Contributor
Author
|
Can I request a small demo gist created under docsify account? Then I can have a live example I can use in my PR. One gist with three files such as:
The README just being an explanation in case anyone stumbles on the gist directly. |
Member
sy-records
approved these changes
Jun 22, 2020
Contributor
Author
Koooooo-7
approved these changes
Jun 22, 2020
trusktr
added a commit
that referenced
this pull request
Jul 4, 2020
* develop: docs: removed codefund docs and plugin (#1262) docs: remove bundle size from the home page and documentation (#1257) fix: search can not search the table header (#1256) fix: after setting the background image, the button is obscured (#1234) Fix: fixed onlycover flag in mobile (#1243) fix: Updated docs with instructions for installing specific version (fixes #780) (#1225) fix: Add error handling for missing dependencies (fixes #1210) (#1232) [documdocs: deploy docsify in docker. (#1241) docs: Add embed gist instructions to Embed Files (fixes #932 ) (#1238) chore: add changelog 4.11.4 [build] 4.11.4 feat: added html sanitizer for remote rendering (#1128)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added gist instructions to Embed Files page. Closes #982.
Also cleaned up the grammar on the first part of the page.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)Other information:
libdirectory.