{{ message }}
This repository was archived by the owner on Oct 26, 2019. It is now read-only.
Allow to push image#121
Merged
Merged
Conversation
Contributor
Contributor
Author
|
@hacfi yes, it is. |
Contributor
|
Haven’t tried this but looks good to me! @sroze Will this work with both Docker Hub and private registries? |
Contributor
Author
|
@hacfi it is, for private repositories you have have to have an image name like |
sroze
force-pushed
the
feature/image-push
branch
from
25912e7 to
9674c4e
Compare
Contributor
Author
|
ping @hacfi |
Contributor
|
Looks good to me but I can’t merge it as I’m just a contributor. |
Contributor
|
@ubermuda, @joelwurtz: Pretty please! |
Contributor
|
Hey @sroze, thanks for your contribution! Can you rebase this on master? I just merged in some fixes to unit test running in travis |
sroze
force-pushed
the
feature/image-push
branch
from
9674c4e to
ca97551
Compare
Contributor
Author
|
@ubermuda I did but still failing, without any relation with this PR. |
Contributor
|
That's right, I'll have to take a look at this later :) |
Contributor
Author
|
Thanks @ubermuda ! Anyway you can release a minor version ? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a
pushmethod on the image manager that allows to push an image to a registry.