{{ message }}
fix: setup email restrict configs should only prepend once#4379
Merged
Conversation
Member
Author
…all `smtpd` ports
Member
Author
casperklein
approved these changes
Feb 20, 2025
georglauterbach
approved these changes
Mar 1, 2025
This was referenced Mar 4, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
I've noticed that
/etc/postfix/main.cfhas these checks prepended twice, as the Postfix parameter we update also has thesedcall match our owndms_prefix variant (introduced in #3127).No known bugs, nor should this fix change anything other than removing the duplicates prepended to
smtpd_sender_restrictions, onlydms_smtpd_sender_restrictionswill be configured with these restrictions.EDIT: There was a slight mishap with recipient restrictions in this PR. It was resolved in a follow-up PR for the same 15.0.1 release: #4399
Quick reference for maintainers
To configure how the sender addresses of mail is restricted, DMS has a few similar settings due to:
smtpd_sender_restrictions = $dms_smtpd_sender_restrictions(main.cf)-o smtpd_sender_restrictions=$mua_sender_restrictions(master.cf)That translates to the following:
smtpd_sender_restrictionsis now only from port 25 (inbound)$mua_sender_restrictionsis only for ports 587 + 465$dms_smtpd_sender_restrictionsis used by all 3smtpdports (25, 587, 465).To keep the same behaviour DMS already has for
setup email restricton all ports, we now only prepend todms_smtpd_sender_restrictions.Type of change
Checklist
CHANGELOG.md