chore: remove `VERSION` file by georglauterbach · Pull Request #4321 · docker-mailserver/docker-mailserver · GitHub
Skip to content

chore: remove VERSION file#4321

Merged
georglauterbach merged 3 commits into
masterfrom
gl/remove-version
Jan 19, 2025
Merged

chore: remove VERSION file#4321
georglauterbach merged 3 commits into
masterfrom
gl/remove-version

Conversation

@georglauterbach

Copy link
Copy Markdown
Member

Description

Fixes #3677

ref #4302

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
@georglauterbach georglauterbach added priority/medium area/configuration (file) kind/update Update an existing feature, configuration file or the documentation labels Jan 18, 2025
@georglauterbach georglauterbach added this to the v15.0.0 milestone Jan 18, 2025
@georglauterbach georglauterbach self-assigned this Jan 18, 2025
@georglauterbach

Copy link
Copy Markdown
Member Author

polarathene
polarathene previously approved these changes Jan 18, 2025

@polarathene polarathene left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub does not seem to run the CI against the merged changes, hence CI fails.

Yeah we have the CI workflow pointing at the latest master branch commit for reusable workflows like the image build or tests (it's only the workflow part, they'll use the PR branch for building/testing).

LGTM! 👍

Comment thread .github/workflows/generic_build.yml Outdated
Co-authored-by: Casper <casperklein@users.noreply.github.com>
@georglauterbach georglauterbach merged commit f0daa1c into master Jan 19, 2025
@georglauterbach georglauterbach deleted the gl/remove-version branch January 19, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/configuration (file) kind/update Update an existing feature, configuration file or the documentation priority/medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TODO]: Remove VERSION

3 participants