Add windows servers to smoke test by yosifkit · Pull Request #83 · docker-library/bashbrew · GitHub
Skip to content

Add windows servers to smoke test#83

Merged
tianon merged 1 commit into
masterfrom
windows-workflow
Sep 26, 2023
Merged

Add windows servers to smoke test#83
tianon merged 1 commit into
masterfrom
windows-workflow

Conversation

@yosifkit

@yosifkit yosifkit commented Sep 25, 2023

Copy link
Copy Markdown
Member

Disable cgo to fix build failure on GHA windows-2022

Example failure from PRs to official-images:

go: downloading github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da
# github.com/docker-library/bashbrew/cmd/bashbrew
C:\hostedtoolcache\windows\go\1.18.10\x64\pkg\tool\windows_amd64\link.exe: running gcc failed: exit status 1
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-3224421645\000008.o: in function `_cgo_preinit_init':
\\_\_\runtime\cgo/gcc_libinit_windows.c:30: undefined reference to `__imp___iob_func'
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-3224421645\000008.o: in function `x_cgo_sys_thread_create':
\\_\_\runtime\cgo/gcc_libinit_windows.c:60: undefined reference to `__imp___iob_func'
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-3224421645\000008.o: in function `x_cgo_notify_runtime_init_done':
\\_\_\runtime\cgo/gcc_libinit_windows.c:101: undefined reference to `__imp___iob_func'
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-3224421645\000009.o: in function `x_cgo_thread_start':
\\_\_\runtime\cgo/gcc_util.c:18: undefined reference to `__imp___iob_func'
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-3224421645\000010.o: in function `_cgo_sys_thread_start':
\\_\_\runtime\cgo/gcc_windows_amd64.c:31: undefined reference to `__imp___iob_func'
collect2.exe: error: ld returned 1 exit status

@codecov-commenter

codecov-commenter commented Sep 25, 2023 •
edited
Loading

Copy link
Copy Markdown

tianon
tianon reviewed Sep 25, 2023
View reviewed changes
Comment thread action.yml Outdated
with:
go-version-file: '${{ github.action_path }}/go.mod'
env:
CGO_ENABLED: 0

@tianon tianon Sep 25, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we instead add this to

bashbrew/bashbrew.sh

Line 9 in 6334a4f

export GO111MODULE=on
?

(with : "${CGO_ENABLED:=0}")

@yosifkit yosifkit Sep 25, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think that makes sense.

$ git grep -i cgo
Dockerfile:RUN CGO_ENABLED=0 ./bashbrew.sh --version; \
Dockerfile.release:ENV CGO_ENABLED 0
action.yml:        CGO_ENABLED: 0

@yosifkit yosifkit Sep 25, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now moved to bashbrew.sh. We could drop it from the Dockerfile but it seems fine to be explicit there and in the Dockerfile.release.

$ git grep -i cgo
Dockerfile:RUN CGO_ENABLED=0 ./bashbrew.sh --version; \
Dockerfile.release:ENV CGO_ENABLED 0
bashbrew.sh:: "${CGO_ENABLED:=0}"
bashbrew.sh:export GO111MODULE=on CGO_ENABLED

@yosifkit
Add windows servers to smoke test
c4273aa 
Disable cgo to fix build failure on GHA windows-2022
@tianon tianon merged commit a226be9 into master Sep 26, 2023
@tianon tianon deleted the windows-workflow branch September 26, 2023 01:12
@yosifkit yosifkit mentioned this pull request Oct 12, 2023
Merged
@whalelines

whalelines commented Oct 24, 2023

Copy link
Copy Markdown

Is there a reason to disable for all rather than just for windows?

@yosifkit

yosifkit commented Oct 24, 2023

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon tianon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yosifkit @codecov-commenter @whalelines @tianon @bigmitch37