Bug-fix: mapping "networks" in statistics by bonigarcia · Pull Request #360 · docker-java/docker-java · GitHub
Skip to content

Bug-fix: mapping "networks" in statistics#360

Closed
bonigarcia wants to merge 0 commit into
docker-java:masterfrom
bonigarcia:master
Closed

Bug-fix: mapping "networks" in statistics#360
bonigarcia wants to merge 0 commit into
docker-java:masterfrom
bonigarcia:master

Conversation

@bonigarcia

Copy link
Copy Markdown
Contributor

There is a bug in the mapping of the network statistics. Currently, calling to com.github.dockerjava.api.model.Statistics.getNetworkStats() returns null.

@KostyaSha

Copy link
Copy Markdown
Member

@bonigarcia

Copy link
Copy Markdown
Contributor Author

I am using Docker version 1.9.0, build 76d6bc9.

@bonigarcia

Copy link
Copy Markdown
Contributor Author

I tested with docker-java 2.1.1, 2.1.2 and 3.0.0-SNAPSHOT. Both of three have the same bug.

@KostyaSha

Copy link
Copy Markdown
Member

Sorry, i mean docker host API

@bonigarcia

Copy link
Copy Markdown
Contributor Author

I am using Docker 1.9.0, and according to Docker documentation, API version should be 1.21.

@marcuslinke

Copy link
Copy Markdown
Contributor

@KostyaSha

Copy link
Copy Markdown
Member

@marcuslinke seems it because it now support multiple interfaces. The right way to fix will be add new field, mark as @Deprecated with specifying docker API versions.

@KostyaSha

Copy link
Copy Markdown
Member

moby/moby#16564

@marcuslinke

Copy link
Copy Markdown
Contributor

@KostyaSha Right. I agree.

@bonigarcia Could you do so?

@KostyaSha

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants