Extra Serializer classes for VolumeBinds and VolumesRW by oleg-nenashev · Pull Request #212 · docker-java/docker-java · GitHub
Skip to content

Extra Serializer classes for VolumeBinds and VolumesRW#212

Merged
marcuslinke merged 4 commits into
docker-java:masterfrom
oleg-nenashev:issue_211
May 7, 2015
Merged

Extra Serializer classes for VolumeBinds and VolumesRW#212
marcuslinke merged 4 commits into
docker-java:masterfrom
oleg-nenashev:issue_211

Conversation

@oleg-nenashev

Copy link
Copy Markdown
Contributor

Resolves #211 by introducing missing serializers.
The pull request also provides a simple framework for data object roundtrip tests.

@marcuslinke @reviewbybees

@marcuslinke

Copy link
Copy Markdown
Contributor

@oleg-nenashev

Copy link
Copy Markdown
Contributor Author

As i see your test case doesn't actually really test VolumeBinds and VolumesRW serialization. So this should be fixed.

Agreed. I've taken a JSON sample with empty fields, which is not enough. I'll add more tests

However, I would recommend to test the serialization roundtrip of a real ContainerInspectResponse as part of the InspectExecCommandImplTest because the ContainerInspectResponse maybe change with the next docker API versions. WDYT?

An additional test on the real data would be useful to check the integration. I'll integrate such check. I would also keep unit tests on pre-defined samples as well, because we cannot reproduce all cases on real responses.

@marcuslinke

Copy link
Copy Markdown
Contributor

👍

@oleg-nenashev

Copy link
Copy Markdown
Contributor Author

The new version is ready

marcuslinke added a commit that referenced this pull request May 7, 2015
Extra Serializer classes for VolumeBinds and VolumesRW
@marcuslinke marcuslinke merged commit 0dd4944 into docker-java:master May 7, 2015
@oleg-nenashev

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roundtrip of InspectContainerResponse fails (VolumeBinds)

2 participants