{{ message }}
Extra Serializer classes for VolumeBinds and VolumesRW#212
Merged
Conversation
Contributor
Contributor
Author
Agreed. I've taken a JSON sample with empty fields, which is not enough. I'll add more tests
An additional test on the real data would be useful to check the integration. I'll integrate such check. I would also keep unit tests on pre-defined samples as well, because we cannot reproduce all cases on real responses. |
Contributor
|
👍 |
Contributor
Author
|
The new version is ready |
marcuslinke
added a commit
that referenced
this pull request
May 7, 2015
Extra Serializer classes for VolumeBinds and VolumesRW
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #211 by introducing missing serializers.
The pull request also provides a simple framework for data object roundtrip tests.
@marcuslinke @reviewbybees