4.80 docs updates#25430
Conversation
Signed-off-by: aevesdocker <allie.sadler@docker.com>
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
| Synchronized file shares is ideal for developers who: | ||
| - Have large repositories or monorepos with 100 000 files or more totaling hundreds of megabytes or even gigabytes. | ||
| - Are using virtual filesystems, such as VirtioFS, gRPC FUSE, and osxfs, which are no longer scaling well with their codebases. | ||
| - Are using virtual filesystems, such as VirtioFS and gRPC FUSE which are no longer scaling well with their codebases. |
There was a problem hiding this comment.
[MEDIUM] Missing comma before non-restrictive relative clause
The original text had "VirtioFS, gRPC FUSE, and osxfs, which are no longer scaling well" — the comma before which belonged to the three-item list. After removing osxfs, the trailing comma was dropped too, but the non-restrictive relative clause "which are no longer scaling well with their codebases" still requires a comma before it.
Suggested fix:
- Are using virtual filesystems, such as VirtioFS and gRPC FUSE, which are no longer scaling well with their codebases.
There was a problem hiding this comment.
[MEDIUM] "Both false" fallback behavior left undocumented after osxfs removal
The removed sentence documented what Docker Desktop does when both useVirtualizationFrameworkVirtioFS and useGrpcfuse are set to false. With osxfs gone, that fallback no longer applies — but the new text says nothing about the both-false case.
Administrators locking these settings in admin-settings.json need to know what file sharing mechanism is used when both values are false. Consider documenting the new default behavior (e.g., "If both are set to false, Docker Desktop uses the default file sharing mechanism") or noting that at least one should be set to true.

Description
as per https://github.com/docker/pinata/pull/41635
Related issues or tickets
Reviews