4.80 docs updates by aevesdocker · Pull Request #25430 · docker/docs · GitHub
Skip to content

4.80 docs updates#25430

Draft
aevesdocker wants to merge 1 commit into
docker:mainfrom
aevesdocker:4.80-docs-updates
Draft

4.80 docs updates#25430
aevesdocker wants to merge 1 commit into
docker:mainfrom
aevesdocker:4.80-docs-updates

Conversation

@aevesdocker

Copy link
Copy Markdown
Contributor

Description

as per https://github.com/docker/pinata/pull/41635

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

Signed-off-by: aevesdocker <allie.sadler@docker.com>
@github-actions github-actions Bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Jun 24, 2026
@netlify

netlify Bot commented Jun 24, 2026

Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟡 NEEDS ATTENTION

Synchronized file shares is ideal for developers who:
- Have large repositories or monorepos with 100 000 files or more totaling hundreds of megabytes or even gigabytes.
- Are using virtual filesystems, such as VirtioFS, gRPC FUSE, and osxfs, which are no longer scaling well with their codebases.
- Are using virtual filesystems, such as VirtioFS and gRPC FUSE which are no longer scaling well with their codebases.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEDIUM] Missing comma before non-restrictive relative clause

The original text had "VirtioFS, gRPC FUSE, and osxfs, which are no longer scaling well" — the comma before which belonged to the three-item list. After removing osxfs, the trailing comma was dropped too, but the non-restrictive relative clause "which are no longer scaling well with their codebases" still requires a comma before it.

Suggested fix:

- Are using virtual filesystems, such as VirtioFS and gRPC FUSE, which are no longer scaling well with their codebases.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEDIUM] "Both false" fallback behavior left undocumented after osxfs removal

The removed sentence documented what Docker Desktop does when both useVirtualizationFrameworkVirtioFS and useGrpcfuse are set to false. With osxfs gone, that fallback no longer applies — but the new text says nothing about the both-false case.

Administrators locking these settings in admin-settings.json need to know what file sharing mechanism is used when both values are false. Consider documenting the new default behavior (e.g., "If both are set to false, Docker Desktop uses the default file sharing mechanism") or noting that at least one should be set to true.

@aromal-a

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/desktop Issue affects a desktop edition of Docker. E.g docker for mac

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants