{{ message }}
Make docker-users workaround script idempotent#25424
Open
devendrakushwah80 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Enterprise Deployment FAQ PowerShell workaround script so it won’t fail when the docker-users local group already exists, improving reliability for repeated/automated execution.
Changes:
- Adds an existence check (
Get-LocalGroup ... -ErrorAction SilentlyContinue) before callingNew-LocalGroup. - Keeps the script behavior focused on ensuring the current user is added to
docker-users.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the workaround script in the Enterprise Deployment FAQ to avoid recreating the
docker-usersgroup when it already exists.The current script unconditionally calls
New-LocalGroup, which can fail if the group is already present. This change makes the script idempotent by checking for the group's existence before creating it.Related issues or tickets
Fixes #25420
Reviews