{{ message }}
sbx: clarify clone behavior#25423
Open
craig-osterhout wants to merge 4 commits into
Open
Conversation
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Contributor
Author
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
Two medium findings in — both concern the same added block about untracked/ignored files being readable inside the sandbox. The security warning and action recommendation are embedded inside an existing bullet rather than surfaced as a callout, which is inconsistent with how the direct-mount section handles equivalent guidance.
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarified that with clone mode, agent can still read untracked & .gitignored files.
Related issues or tickets
docker/sbx-releases#260
https://docker.slack.com/archives/C0B1XV3FQMU/p1782148268612729
Reviews