dhi: add aws inspector by craig-osterhout · Pull Request #25365 · docker/docs · GitHub
Skip to content

dhi: add aws inspector#25365

Open
craig-osterhout wants to merge 2 commits into
docker:mainfrom
craig-osterhout:engdocs-3330
Open

dhi: add aws inspector#25365
craig-osterhout wants to merge 2 commits into
docker:mainfrom
craig-osterhout:engdocs-3330

Conversation

@craig-osterhout

@craig-osterhout craig-osterhout commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Description

Added info about AWS Inspector support for DHI.

image

Preview: https://deploy-preview-25365--docsdocker.netlify.app/dhi/explore/scanner-integrations/

Related issues or tickets

ENGDOCS-3330

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify

netlify Bot commented Jun 15, 2026

Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The added content correctly documents AWS Inspector as a scanner that works with Docker Hardened Images but doesn't apply VEX filtering. The prose is clear, well-scoped, and consistent with the existing document's tone.

One apparent URL concern — the AWS Inspector suppression rules link uses supression (one 'p') in the path — was verified against the live AWS documentation URL. AWS's own URL slug uses the misspelled word (findings-managing-supression-rules.html, HTTP 200), while the correctly-spelled URL redirects to their homepage. The link is correct as written.

@craig-osterhout craig-osterhout added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Jun 15, 2026
@craig-osterhout craig-osterhout marked this pull request as draft June 15, 2026 23:49
@craig-osterhout craig-osterhout marked this pull request as ready for review June 23, 2026 17:21
@craig-osterhout craig-osterhout removed the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Jun 23, 2026

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟡 NEEDS ATTENTION

The PR correctly adds AWS Inspector to the scanner integrations table and updates front matter keywords. One medium issue was found: the new paragraph uses the abbreviation DHI without formally introducing it earlier in the document.

Comment thread content/manuals/dhi/explore/scanner-integrations.md Outdated
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
@craig-osterhout craig-osterhout added the status/review Pull requests that are ready for review label Jun 23, 2026
@craig-osterhout craig-osterhout requested a review from a team June 23, 2026 17:27
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dhi status/review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants