Fix check_2 to -le 644 by jammasterj89 · Pull Request #461 · docker/docker-bench-security · GitHub
Skip to content

Fix check_2 to -le 644 - #461

Merged
konstruktoid merged 2 commits into
docker:masterfrom
jammasterj89:master
Jan 15, 2021
Merged

konstruktoid merged 2 commits into
docker:masterfrom
jammasterj89:master

Conversation

@jammasterj89

Copy link
Copy Markdown
Contributor

Issue #459 raised that check_2 was only checking for 644 or 600 permissions, this now checks for anything less than or equal to 644.

Signed-off-by: Niall T 19202716+jammasterj89@users.noreply.github.com

Issue docker#459 raised that check_2 was only checking for 644 or 600 permissions, this now checks for anything less than or equal to 644.

Signed-off-by: Niall T 19202716+jammasterj89@users.noreply.github.com
@konstruktoid

Copy link
Copy Markdown
Collaborator

Replace multiple -eq with -le for file permission checks. Except for line 228 which uses slightly different logic so is -ge.

Signed-off-by: Niall T 19202716+jammasterj89@users.noreply.github.com
Comment thread tests/3_docker_daemon_configuration_files.sh
@konstruktoid

Copy link
Copy Markdown
Collaborator

Thanks alot @jammasterj89!

@jammasterj89

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants