{{ message }}
Repository navigation
test(teamloader): stop LSP tests from auto-installing gopls - #4647
Merged
Merged
Conversation
The LSP toolset tests only check toolset wiring and never start the server, but lsp.CreateToolSet calls toolinstall.EnsureCommand, which runs `go install gopls` when it is not on PATH. On CI that made them fail whenever proxy.golang.org hiccuped. Use the per-toolset `version: false` opt-out so no install happens. Fixes docker#4642 Fixes docker#4643 Fixes docker#4644
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The existing installation opt-out preserves the tested behavior, and these tests do not require a running language server.
No open issues 🎉
What changed in this PR
Removes the Go module proxy dependency from three teamloader wiring tests, addressing the reported CI failures without changing production behavior.
Changes:
- Uses
Version: "false"to disable automatic gopls installation. - Preserves existing multiplexing, wrapping, and working-directory assertions.
Review effort: Balanced
aheritier
added
area/agent
aheritier
enabled auto-merge
October 19, 2026 20:04
dgageot
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TestGetToolsForAgent_MultipleLSPToolsetsAreCombined,TestGetToolsForAgent_SingleLSPToolsetNotWrappedandTestCreateLSPTool_WorkingDir_ReachesHandlerfailed together in run 39267593437 with:These tests only check toolset wiring (multiplexing, no wrapping,
WorkingDir). They never start the server:lsp.ToolSet.Tools()returns the static catalogue before the server connects. Butlsp.CreateToolSetcallstoolinstall.EnsureCommand, which runs a realgo installwhengoplsisn't on PATH, as on CI runners. That makes the tests depend on the Go module proxy being up.Fix
Set
Version: "false"on those toolsets. It's the existing per-toolset auto-install opt-out. I didn't useDOCKER_AGENT_AUTO_INSTALL=falsebecause the tests callt.Parallel(), which rules outt.Setenv.Verification
goplsremoved from PATH and an emptyDOCKER_AGENT_TOOLS_DIR. They passed in ~0.01s each, printed noInstalling gopls, and left the tools dir empty.go test -race ./pkg/teamloader/passes.golangci-lintv2.14.0 andgo run ./lint .report no issues.Fixes #4642
Fixes #4643
Fixes #4644