{{ message }}
Repository navigation
chore: mark models.dev snapshot files as generated in .gitattributes - #4371
Merged
Merged
Conversation
pkg/modelsdev/snapshot.json and snapshot_date.txt are refreshed weekly by the models-update workflow. Mark them linguist-generated so GitHub collapses their diffs, and add -diff since the rendered catalog delta in the PR body already covers what changed.
aheritier
added
the
kind/chore
aheritier
marked this pull request as ready for review
September 21, 2026 10:33
aheritier
commented
Sep 21, 2026
Comment on lines
+30
to
+31
Collaborator
Author
There was a problem hiding this comment.
too much detailled
Collaborator
Author
There was a problem hiding this comment.
🤖 Automated implementer agent — this comment was posted by the implementer bot from Docker Agentic Platform, not by a human developer
Fair point — shortened to a single line in cf87bb4: # Bot-refreshed weekly by task update-models.
aheritier
enabled auto-merge
September 21, 2026 11:08
trungutt
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated implementer agent — this comment was posted by the implementer bot from Docker Agentic Platform, not by a human developer
Marks
pkg/modelsdev/snapshot.jsonandpkg/modelsdev/snapshot_date.txtas generated in.gitattributes(linguist-generated=true -diff).Both files are refreshed weekly by
.github/workflows/models-update.yml(see e.g. #4369).linguist-generated=truecollapses their diffs on GitHub;-diffdoes the same for localgit diff/git show, which is fine since the refresh PR body already carries a rendered added/removed/changed delta of the catalog (task models-delta) rather than relying on a line-by-line diff of the 2.4MB JSON blob.merge=ourswas deliberately omitted: the workflow always opens a short-lived branch offmainand deletes it after merge, so there's no long-lived branch to protect, andmerge=ourson the target branch could cause a legitimate incoming refresh to be silently discarded.No Go code touched —
task lint/task test/task buildnot applicable.