{{ message }}
Repository navigation
refactor: simplify literals with Go 1.27 promoted fields - #4324
Merged
Merged
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
aheritier
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Go 1.27 allows promoted fields in composite literals, meaning that when a struct type embeds another, the embedding struct's fields can be set directly in the outer literal without nesting a redundant by-value wrapper. Several composite literals in the runtime and config packages were still using the old style — wrapping an embedded
ConfigorSubSessionConfigwith an explicit field name even though the fields it contains are directly promoted.This change replaces those redundant wrapper layers with direct promoted-field assignment across five files:
pkg/config/runtime_test.go,pkg/config/runtime_clone_test.go,pkg/runtime/agent_delegation.go,pkg/runtime/agent_delegation_test.go, andpkg/runtime/skill_runner.go. All expressions, evaluation order, nil and zero values are preserved exactly. No frozen versioned config packages (pkg/config/v0,pkg/config/v1, …) are touched.This is a targeted, explicit migration of the five files identified in the Go 1.27 review, not a repository-wide
go fixrun. Lint settings are unchanged. Two test cases (TestLoadExamples/../../examples/dmr.yamlandunload_on_switch.yaml) were skipped during the final test run because Docker Model Runner is not running locally; the identical failures reproduce on the unmodified base commit6929d9c13, confirming they are pre-existing environment constraints unrelated to this change.