api: RunOptions documents its partial embedding and its double life a… · docker/compose@a272929 · GitHub
Skip to content

Commit a272929

Browse files
committed
api: RunOptions documents its partial embedding and its double life as ExecOptions
RunOptions embeds CreateOptions, which suggests every creation option applies to the one-off's dependencies; in reality only Build, IgnoreOrphans, RemoveOrphans and QuietPull are propagated (startDependencies builds a fresh CreateOptions from exactly those four). Setting Recreate or Inherit on a RunOptions was a silent no-op. The same struct also serves Exec, which honors only the exec-relevant subset of its ~20 fields. Both facts are now stated on the type, the embedding and the Exec-only Index field. Part of #14074 (B: pkg/api promises things the implementation does not honor). Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
1 parent a07809c commit a272929

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

‎pkg/api/api.go‎

Lines changed: 9 additions & 2 deletions

0 commit comments

Comments
 (0)