api: StartOptions says which half of it Start actually reads · docker/compose@a07809c · GitHub
Skip to content

Commit a07809c

Browse files
committed
api: StartOptions says which half of it Start actually reads
StartOptions fuses two contracts: the fields s.start honors (Project, AttachTo-as-project-source, Wait, WaitTimeout) and the fields only Up's foreground session reads (Attach, OnExit, ExitCodeFrom, Watch, NavigationMenu). Passing the latter to Start compiled, returned no error, and did nothing. Each session field is now marked 'honored by Up's foreground session only; ignored by Start'. Two implicit behaviors become explicit along the way: Attach doubles as the detached/interactive mode switch (nil means Up returns once containers are started), and AttachTo has two unrelated meanings (project reconstruction source for Start, log scoping for Up). Part of #14074 (B: pkg/api promises things the implementation does not honor). Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
1 parent a06789d commit a07809c

1 file changed

Lines changed: 18 additions & 6 deletions

File tree

‎pkg/api/api.go‎

Lines changed: 18 additions & 6 deletions

0 commit comments

Comments
 (0)