Always enable experimental features by thaJeztah · Pull Request #2774 · docker/cli · GitHub
Skip to content

Always enable experimental features - #2774

Merged
silvin-lubecki merged 2 commits into
docker:masterfrom
thaJeztah:drop_experimental
Oct 2, 2020
Merged

silvin-lubecki merged 2 commits into
docker:masterfrom
thaJeztah:drop_experimental

Conversation

@thaJeztah

@thaJeztah thaJeztah commented Oct 2, 2020 •

Copy link
Copy Markdown
Member

replaces / closes #1355
fixes #947

The CLI disabled experimental features by default, requiring users to set a configuration option to enable them.

Disabling experimental features was a request from Enterprise users that did not want experimental features to be accessible.

We are changing this policy, and now enable experimental features by default. Experimental features may still change and/or removed, and will be highlighted in the documentation and "usage" output.

For example, the docker manifest inspect --help output now shows:

EXPERIMENTAL:
  docker manifest inspect is an experimental feature.

  Experimental features provide early access to product functionality. These features
  may change between releases without warning or can be removed entirely from a future
  release. Learn more about experimental features: https://docs.docker.com/go/experimental/

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Comment thread cli-plugins/manager/metadata.go Outdated
Comment thread kubernetes/check.go Outdated
Comment thread kubernetes/check.go Outdated
@thaJeztah
thaJeztah force-pushed the drop_experimental branch 2 times, most recently from 48d4970 to 3f612d9 Compare October 2, 2020 12:39
@thaJeztah

This comment has been minimized.

@thaJeztah
thaJeztah force-pushed the drop_experimental branch 2 times, most recently from 0d9e669 to 60a8584 Compare October 2, 2020 13:28
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter

Copy link
Copy Markdown

The CLI disabled experimental features by default, requiring users
to set a configuration option to enable them.

Disabling experimental features was a request from Enterprise users
that did not want experimental features to be accessible.

We are changing this policy, and now enable experimental features
by default. Experimental features may still change and/or removed,
and will be highlighted in the documentation and "usage" output.

For example, the `docker manifest inspect --help` output now shows:

    EXPERIMENTAL:
      docker manifest inspect is an experimental feature.

      Experimental features provide early access to product functionality. These features
      may change between releases without warning or can be removed entirely from a future
      release. Learn more about experimental features: https://docs.docker.com/go/experimental/

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

Copy link
Copy Markdown
Member Author

@silvin-lubecki silvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki
silvin-lubecki merged commit 6916b42 into docker:master Oct 2, 2020
@thaJeztah
thaJeztah deleted the drop_experimental branch October 2, 2020 15:36
albers added a commit to albers/docker-cli that referenced this pull request Nov 10, 2020
This amends docker#2774 for bash completion.

Signed-off-by: Harald Albers <github@albersweb.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker manifest commands don't work on 18.03.0-ce-rc3

4 participants