{{ message }}
fix: error type hints in Python3.12 (#1147)#1840
Merged
JoanFM merged 1 commit intodocarray:mainfrom Dec 22, 2023
Merged
Conversation
samsja
requested changes
Dec 22, 2023
Member
samsja
left a comment
samsja
left a comment
There was a problem hiding this comment.
Thank you very much for the PR.
I am not sure about the implementation. I think it would be nicer if do a if else on the python version rather that relying on catching the exception
Member
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1840 +/- ##
==========================================
- Coverage 85.07% 85.06% -0.02%
==========================================
Files 136 136
Lines 9255 9260 +5
==========================================
+ Hits 7874 7877 +3
- Misses 1381 1383 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
samsja
reviewed
Dec 22, 2023
samsja
approved these changes
Dec 22, 2023
Member
|
I approved, but before merging can you apply black @954-Ivory ? and DCO as well ( you can do |
Contributor
Author
954-Ivory
force-pushed
the
dev
branch
2 times, most recently
from
2d08f10 to
9391424
Compare
Signed-off-by: 954 <510485871@qq.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1839
Description
I encountered the following issue when using langchain in Python 3.12:
langchain-ai/langchain#15016
It caused by this PR (#1147)
Example Code