fix(qdrant): fix non-class type fields by TerboucheHacene · Pull Request #1752 · docarray/docarray · GitHub
Skip to content

fix(qdrant): fix non-class type fields#1752

Merged
JoanFM merged 1 commit intodocarray:mainfrom
TerboucheHacene:fix-qdrant-doc-index
Aug 13, 2023
Merged

fix(qdrant): fix non-class type fields#1752
JoanFM merged 1 commit intodocarray:mainfrom
TerboucheHacene:fix-qdrant-doc-index

Conversation

@TerboucheHacene
Copy link
Copy Markdown
Contributor

Issue Resolved: Issue with Defining Index of Type QdrantDocumentIndex for Documents with Non-Class Type Fields

Description:
This pull request addresses the issue where defining an index of type QdrantDocumentIndex for documents containing fields with non-class types resulted in a TypeError. The issue has been resolved by replacing the usage of issubclass with safe_issubclass

Signed-off-by: TERBOUCHE Hacene <hacene.terbouche@gmail.com>
@JoanFM JoanFM linked an issue Aug 13, 2023 that may be closed by this pull request
6 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 13, 2023

Copy link
Copy Markdown
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests are not due to this PR

@JoanFM JoanFM merged commit 6c77112 into docarray:main Aug 13, 2023
@JoanFM
Copy link
Copy Markdown
Member

JoanFM commented Aug 13, 2023

@alaeddine-13 alaeddine-13 changed the title fix(qdrant): fix non-class type fields #1748 fix(qdrant): fix non-class type fields Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when using non-class type field in Document with QdrantDocumentIndex

2 participants