{{ message }}
refactor: do not recompute every time num_docs#1729
Merged
Conversation
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
…num-docs Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
jupyterjazz
reviewed
Jul 26, 2023
jupyterjazz
suggested changes
Jul 26, 2023
Contributor
jupyterjazz
left a comment
jupyterjazz
left a comment
There was a problem hiding this comment.
value of k should not be more than number of vectors, otherwise lgtm
jupyterjazz
approved these changes
Jul 26, 2023
Contributor
jupyterjazz
left a comment
jupyterjazz
left a comment
There was a problem hiding this comment.
I wasn't aware of this issue. Let's add 1-2 sentences in the code to explain why we're doing this
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.