{{ message }}
refactor: more robust method to detect duplicate index#1651
Merged
hsm207 merged 9 commits intodocarray:mainfrom Jul 10, 2023
Merged
refactor: more robust method to detect duplicate index#1651hsm207 merged 9 commits intodocarray:mainfrom
hsm207 merged 9 commits intodocarray:mainfrom
Conversation
…07/refactor-duplicate-index
ef6e251 to
c57d576
Compare
Contributor
Author
JoanFM
requested changes
Jul 10, 2023
Member
JoanFM
left a comment
There was a problem hiding this comment.
I guess u need to commit pyproject updated and not only poetry.lock?
Contributor
Author
the pyproject.toml file already has what I want when I pulled from main i.e.:
I don't know if this is the expected behavior, but after the pull, I ran |
Member
|
Not sure, but in that case, I would not update the |
Member
|
Why is there a need to update the lock file ? Not sure that I follow |
This reverts commit eb3c3d2.
…07/refactor-duplicate-index
24aece2 to
fb48a40
Compare
Contributor
Author
JoanFM
approved these changes
Jul 10, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fixes #1357