{{ message }}
Make Record serializable again#242
Merged
Merged
Conversation
ibauersachs
force-pushed
the
serializable-record
branch
from
05e0f0a to
67923aa
Compare
Instead of relying on the unstable default Java serialization of each record type, this uses a proxy object. The proxy object only contains the DNS wire data of a record, which is guaranteed to be stable. This avoids all concerns about compatibility when Record classes evolve and with inheritance. Closes #132 See #114
ibauersachs
force-pushed
the
serializable-record
branch
from
67923aa to
06e2334
Compare
nresare
approved these changes
Jan 22, 2022
nresare
left a comment
nresare
left a comment
Member
There was a problem hiding this comment.
We are fortunate in this project that we happen to have a very battle tested serialisation format for our value objects :)
As an aside, I don't think that the serialisation support in java was ever very well thought out to begin with, but that is not the fault of this change. It is simply magic that adding a non-public non-overriding writeReplace() method changes the serialisation behaviour.
ibauersachs
added a commit
that referenced
this pull request
Jan 23, 2022
- Serializable updates for #242 - History on GitHub is not so important anymore, move it down - Update links to RFCs - Improve doc about the SPI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of relying on the unstable default Java serialization of each
record type, this uses a proxy object. The proxy object only contains
the DNS wire data of a record, which is guaranteed to be stable. This
avoids all concerns about compatibility when Record classes evolve and
with inheritance.
Closes #132
See #114