{{ message }}
Fixed an issue where CodeDom would be disabled post-upgrade#7222
Merged
Conversation
Fixes dnnsoftware#7213 A two step process was put in place to disable CodeDom compilation before its upgrade and re-enable it aftewards. This was implemented in dnnsoftware#6455 However when upgrading from-to the same version, something did not go right and no changes were detected upon the last step of that process. With this PR the change detection appears to be fixed and the web.config saves after the second XmlMerge. I have tested upgrades from 10.2.4 and 10.3.0 as well as a clean install and the web.config is fine after each of those scenarios. This PR includes the changes from dnnsoftware#7221 as I could not build without it, so merging the other first will make this one easier to review.
bdukes
approved these changes
Apr 20, 2026
1 task
mitchelsellers
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7213
A two step process was put in place to disable CodeDom compilation before its upgrade and re-enable it aftewards. This was implemented in #6455
However when upgrading from-to the same version, something did not go right and no changes were detected upon the last step of that process. With this PR the change detection appears to be fixed and the web.config saves after the second XmlMerge.
I have tested upgrades from 10.2.4 and 10.3.0 as well as a clean install and the web.config is fine after each of those scenarios.
This PR includes the changes from #7221 as I could not build without it, so merging the other first will make this one easier to review.