{{ message }}
Fix the automated code generation for double and bool properties #573
Merged
marvinoe21 merged 5 commits intoDec 18, 2024
Conversation
…ython Task wizard
rainman110
reviewed
Dec 16, 2024
rainman110
left a comment
rainman110
left a comment
Contributor
There was a problem hiding this comment.
From what i understand and see, this looks good.
I cannot estimate potential side effects though. Can you please comment on this?
Is it possible, to verify the fixed functionality with a test?
Contributor
There was a problem hiding this comment.
What happened to the modeproperty cast?
Collaborator
Author
There was a problem hiding this comment.
Since the mode property is of type GtProperty<QString> it is handled in line 212.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.