{{ message }}
Rotate labels - #54
Open
jswift-stfc wants to merge 16 commits into
Open
Conversation
trisyoungs
requested changes
May 20, 2022
trisyoungs
left a comment
trisyoungs
left a comment
Member
There was a problem hiding this comment.
This is definitely heading down the right lines, but one crucial thing is missing - the rotation of the label isn't accounted for in the bounding cuboids, which means that the layout is generated incorrectly. To illustrate this, run the basic example, set the Y-axis title to "Vertical", and put in a long title. It's clear that the graph area is reacting to an increase in only the horizontal (un-rotated) size of the label.
Contributor
Author
Contributor
Author
|
Regarding this, at which point do you think the rotation should be performed? In reference to the |
Member
…achieve alignment about Z.
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
…l calculated incorrectly).
trisyoungs
force-pushed
the
rotate-labels
branch
from
September 7, 2022 12:52
f192f1e to
60f09cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relatively small PR that enables a
TextEntityto be rotated. This is aimed in particular at Axis Titles.TextAlignmentenum for defining rotation of text (currently horizontal / vertical).TextEntityclass.AxisEntityclass.Current issues:
Closes #13.