{{ message }}
xiiui → Update Visual Editor popover/modal action buttons#27186
Open
formfcw wants to merge 4 commits intoflorian/cms-1945-update-visual-editor-header-bar-buttonsfrom
Conversation
Add --button-height-xs/sm/default/lg/xl to global variables and use them in v-button.vue. Group variables by section.
Move popover action buttons from top to bottom, matching the modal
layout. Replace the action bar shadow with a border and hide it with
a cover when content does not overflow.
Measure popover width dynamically via useElementSize; popoverProps
is now a callback receiving { popoverWidth } and returning partial
VMenuProps, replacing the hardcoded 648px width in editing-layer.
Reorder actions: cancel first, slot, save. Simplify getTooltip into
getSaveShortcut. In drawer mode, use PrivateViewHeaderBarActionButton
with ghost variant for the "navigate to item" action.
Export VMenuProps from v-menu.vue to type the new popoverProps
callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
PrivateViewHeaderBarActionButtonfor "navigate to item".--button-height-*CSS variables (pure refactor).OverlayItem'spopoverPropsbecomes a callback receiving{ popoverWidth }and returningPartial<VMenuProps>.Potential Risks / Drawbacks
popoverPropsonOverlayItemchanges shape (object → callback). However,editing-layer.vueis the only consumer.Tested Scenarios
meta+ssave andesccancel shortcuts and tooltips in the Visual Editor.Review Notes / Questions
Checklist
Addresses CMS-1924