{{ message }}
Repository navigation
Conversation
Print Connecting/Resuming/Connected on stderr so a paused MicroVM no longer looks stuck, fail fast when stdin is not a TTY, and map idle/max-duration server closes to exit 0 with plain messages. Co-authored-by: Cursor <cursoragent@cursor.com>
SSharma-10
reviewed
Sep 30, 2026
Contributor
There was a problem hiding this comment.
These land after we put the terminal in raw mode, so \n alone can leave the cursor mid-line. Can we use \r\n here?
SSharma-10
reviewed
Sep 30, 2026
Comment on lines
+656
to
+657
| case "idle_timeout": | ||
| fmt.Fprintln(os.Stderr, "console closed: no activity for 30 minutes") |
Contributor
There was a problem hiding this comment.
Hardcoding “30 minutes” could become inaccurate if the server idle limit is configurable.
Can we use message when it’s non-empty, or fall back to a generic “idle timeout reached”?
SSharma-10
reviewed
Sep 30, 2026
Comment on lines
+659
to
+660
Contributor
There was a problem hiding this comment.
Same as above, avoid hardcoding “4 hour”, use the server message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doctl compute microvm consoleis run without a TTY.status:resumingand will sendstatus:connectedafter the companion cthulhu PR).idle_timeout,session_max_duration) to exit 0 with plain messages; keepclient_unresponsiveand other codes as errors.Companion: microdroplet customer-facing PTY/exec fixes (MDROP-493 follow-up).
Test plan
go test ./commands/ -run TestConsoleControlErrordoctl compute microvm console <paused-id>shows Resuming then ConnectedMade with Cursor