chore: bring code up to latest group standards by sbillinge · Pull Request #113 · diffpy/diffpy.srfit · GitHub
Skip to content

chore: bring code up to latest group standards#113

Merged
sbillinge merged 60 commits into
mainfrom
migration
Jun 27, 2025
Merged

chore: bring code up to latest group standards#113
sbillinge merged 60 commits into
mainfrom
migration

Merge pull request #117 from sbillinge/flake8

75f570d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 27, 2025 in 0s

67.05% (-14.14%) compared to 4edfa96

View this Pull Request on Codecov

67.05% (-14.14%) compared to 4edfa96

Details

Codecov Report

Attention: Patch coverage is 59.70719% with 633 lines in your changes missing coverage. Please review.

Project coverage is 67.05%. Comparing base (4edfa96) to head (75f570d).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_sgconstraints.py 10.06% 134 Missing ⚠️
tests/test_objcrystparset.py 7.35% 126 Missing ⚠️
tests/test_pdf.py 43.97% 107 Missing ⚠️
tests/test_characteristicfunctions.py 17.47% 85 Missing ⚠️
tests/test_diffpyparset.py 16.66% 75 Missing ⚠️
tests/test_sas.py 18.05% 59 Missing ⚠️
tests/test_speed.py 14.28% 36 Missing ⚠️
tests/conftest.py 88.76% 10 Missing ⚠️
tests/test_fitresults.py 98.41% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4edfa96) and HEAD (75f570d). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (4edfa96) HEAD (75f570d)
8 1
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #113       +/-   ##
===========================================
- Coverage   81.19%   67.05%   -14.14%     
===========================================
  Files          91       25       -66     
  Lines        7599     3160     -4439     
===========================================
- Hits         6170     2119     -4051     
+ Misses       1429     1041      -388
Files with missing lines Coverage Δ
tests/test_builder.py 100.00% <100.00%> (ø)
tests/test_constraint.py 96.96% <100.00%> (ø)
tests/test_contribution.py 99.51% <100.00%> (ø)
tests/test_equation.py 100.00% <100.00%> (ø)
tests/test_fitrecipe.py 99.49% <100.00%> (ø)
tests/test_literals.py 99.17% <100.00%> (ø)
tests/test_parameter.py 98.14% <100.00%> (ø)
tests/test_parameterset.py 94.73% <ø> (ø)
tests/test_profile.py 99.33% <100.00%> (ø)
tests/test_profilegenerator.py 97.95% <100.00%> (ø)
... and 15 more

... and 64 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov