Re-cookiecut: implement codecov, install pdffit2 rc, limit to py3.12 by bobleesj · Pull Request #235 · diffpy/diffpy.pdfgui · GitHub
Skip to content

Re-cookiecut: implement codecov, install pdffit2 rc, limit to py3.12#235

Merged
sbillinge merged 9 commits into
diffpy:mainfrom
bobleesj:recut-codecov
Dec 7, 2024
Merged

Re-cookiecut: implement codecov, install pdffit2 rc, limit to py3.12#235
sbillinge merged 9 commits into
diffpy:mainfrom
bobleesj:recut-codecov

Conversation

@bobleesj

@bobleesj bobleesj commented Dec 7, 2024

Copy link
Copy Markdown
Contributor

Closes #232 - add codecov report in PR
Closes #231 - implement codespell
Closes #230 - add requires-python in pyproject.toml
Closes #236 - fix spelling suggested by Codespell

@codecov

codecov Bot commented Dec 7, 2024

Copy link
Copy Markdown

run: |
conda install --file requirements/test.txt
conda install wxpython diffpy.utils matplotlib-base
pip install diffpy.pdffit2==1.4.4rc6

@bobleesj bobleesj Dec 7, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are testing pdfgui with pdffit rc, we conda install wxpython, diffpy.utils, and matplotlib-base

and then we pip install pdffit2 rc

Once we have pdfgui tested with pdffit2 rc, we could try to find an approach to use the reusable workflow? @sbillinge

@sbillinge sbillinge merged commit dd9f989 into diffpy:main Dec 7, 2024
@sbillinge

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants