You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Next, please copy the .flake8 and black configs (this latter is in pyproject.toml, but don't copy over the whole thing, just the [tool.black] part. create a file with just this in if it is not there) and the pre-commit-config.yaml and start working on the flake8 fixes. Please split them into a few PRs so I am reviewing 4 or 5 files at a time. Periodically run the tests to make sure we didn't break anything!
@sbillinge Do you want me to create a pyproject.toml file with just the [tool.black] section in it? If so, should i remove setup.py?
Good question. Not yet. If there is currently no pyproject.toml file, just create one and paste into it the [tool.black] section but nothing else.
Got it. I already made the first PR with flake8 edits. I copied over the .flake8 file in that PR so the sooner we can get that merged the more I can split up the edits into different PRs, unless there is a better way to do this?
@sbillinge Do you want me to create a pyproject.toml file with just the [tool.black] section in it? If so, should i remove setup.py?
Good question. Not yet. If there is currently no pyproject.toml file, just create one and paste into it the [tool.black] section but nothing else.
Got it. I already made the first PR with flake8 edits. I copied over the .flake8 file in that PR so the sooner we can get that merged the more I can split up the edits into different PRs, unless there is a better way to do this?
I will try and merge it, but the quickest way to get it merged is to put in a PR with just the flake8 file....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.