Add release workflow for GitHub releases by Goooler · Pull Request #2189 · diffplug/spotless · GitHub
Skip to content

Add release workflow for GitHub releases#2189

Closed
Goooler wants to merge 3 commits into
diffplug:mainfrom
Goooler:main
Closed

Add release workflow for GitHub releases#2189
Goooler wants to merge 3 commits into
diffplug:mainfrom
Goooler:main

Conversation

@Goooler

Goooler commented Jul 1, 2024

Copy link
Copy Markdown
Member Author

@nedtwigg nedtwigg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, this has been bothering me for a while. I didn't realize it was as easy as gh release create, but actually that makes sense that github actions has that already logged in.

The logic here is pretty complex. I might be misunderstanding, but it looks like we would want prerelease to true for ffurrer2/extract-release-notes? EDIT: I see from your example that it is already tested, so it must be right I guess

But either way, seems like a better approach is just for this task to call gh blah?

Maybe the API should look like this?

spotlessChanglog {
  afterPushExec "gh release create {{tag}} --title plugin-gradle --notes '{{unreleased}}'"
}

@Goooler

Goooler commented Jul 2, 2024

Copy link
Copy Markdown
Member Author
  1. Something like softprops/action-gh-release can do this release as well, I use GH CLI here as GH officially supports it.
  2. ffurrer2/extract-release-notes is for extracting release notes from changelog files, there might be similar mechanisms implemented by other tools but GH, I filed an issue to Support parsing release notes from changelog files cli/cli#9276.
  3. Yeah we can call gh release ... from the Gradle side, but the key point is how to obtain the release notes, this is why I introduce some action steps here.

@Goooler

Goooler commented Jul 2, 2024

Copy link
Copy Markdown
Member Author

I just filed a new issue about the third part to diffplug/spotless-changelog#49.

Comment thread .github/workflows/deploy.yml Outdated
@nedtwigg

Copy link
Copy Markdown
Member

@nedtwigg nedtwigg closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can we create releases from tags?

2 participants