chore: use GitHub case syntax instead of ternary "if" by nmattia · Pull Request #10139 · dfinity/ic · GitHub
Skip to content

chore: use GitHub case syntax instead of ternary "if" - #10139

Merged
nmattia merged 1 commit into
masterfrom
nm-ternary-case
May 11, 2026
Merged

nmattia merged 1 commit into
masterfrom
nm-ternary-case

Conversation

@nmattia

@nmattia nmattia commented May 8, 2026

Copy link
Copy Markdown
Contributor

Replace ternary ifs (condition && trueValue || falseValue) GitHub Actions workflow files with the new first-class case() expression (actions/runner#409).

The case() expression is now the correct tool for the job and avoids some the "conditional if"
footguns.

Replace ternary ifs (`condition && trueValue || falseValue) GitHub Actions
workflow files with the new first-class `case()` expression (actions/runner#409).

The `case()` expression is now the correct tool for the job and avoids
some the of conditional if
[footguns](actions/runner#409 (comment)).
v#
@github-actions github-actions Bot added the chore label May 8, 2026
@nmattia
nmattia marked this pull request as ready for review May 8, 2026 10:54
@nmattia
nmattia requested a review from a team as a code owner May 8, 2026 10:54
@github-actions github-actions Bot added the @idx label May 8, 2026

@basvandijk basvandijk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@nmattia
nmattia added this pull request to the merge queue May 11, 2026
Merged via the queue into master with commit 371ec23 May 11, 2026
42 checks passed
@nmattia
nmattia deleted the nm-ternary-case branch May 11, 2026 09:13

This branch was previously deployed

1 inactive deployment
CREATE_PR — 00faf346 Deployed May 8, 2026 by nmattia via update-ic-versions-file #2411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants