{{ message }}
This repository was archived by the owner on Dec 15, 2018. It is now read-only.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #41
You can view the security issue in this report.
Solution
I removed the rule
".write": "auth !== null && auth.provider === 'github'"fromv1/users, and hardened the write rule underv1/users/$uidso a user can only write to its own uid.In addition, I removed the read rule from
/v1/users/$uid, since it was useless because of the".read": "auth !== null && auth.provider === 'github'"under/v1/users.From what I saw, the current functionality needs to read all the users, therefore I left it permissive rule.
Note: I didn't removed the problem from the old API, in order not to break anything.
An analysis on the fixed rules can be seen here.