base: Use bat, fd, rg from dnf repos by jnohlgard · Pull Request #258 · devfile/developer-images · GitHub
Skip to content

base: Use bat, fd, rg from dnf repos#258

Open
jnohlgard wants to merge 1 commit into
devfile:mainfrom
jnohlgard:dnf-bat-fd
Open

base: Use bat, fd, rg from dnf repos#258
jnohlgard wants to merge 1 commit into
devfile:mainfrom
jnohlgard:dnf-bat-fd

Conversation

@jnohlgard

@jnohlgard jnohlgard commented May 30, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Using the distro/EPEL packages fixes the broken arch detection in the shell script used to download the releases from GitHub. Also it looks like these packages are available for ppc64 and s390x, in addition to x86_64 and aarch64.

Summary by CodeRabbit

Release Notes

  • Chores
    • Streamlined container image builds by installing CLI tools via package manager instead of manual downloads.
    • Updated container default behavior to remain active during runtime.

Review Change Stack

@openshift-ci

openshift-ci Bot commented May 30, 2026

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented May 30, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8ad8867b-2f14-45c7-a4a2-0793e549abc5

📥 Commits

Reviewing files that changed from the base of the PR and between bacc1e9 and 3217d0b.

📒 Files selected for processing (2)
  • base/ubi10/Dockerfile
  • base/ubi9/Dockerfile
📝 Walkthrough

Walkthrough

Two base Dockerfiles (UBI9 and UBI10) migrate CLI tool installation from per-architecture GitHub-release downloads to DNF package management. Architecture-specific download and extraction logic is removed, and container default commands are set to keep images running.

Changes

Base image CLI tool consolidation

Layer / File(s) Summary
UBI10 image: consolidate CLI tools to package install and set runtime
base/ubi10/Dockerfile		 The dnf install command adds bat to the package list instead of downloading it separately per TARGETARCH. Container default CMD is set to tail -f /dev/null.
UBI9 image: consolidate CLI tools to package install, remove build scripts, and set runtime
base/ubi9/Dockerfile		 The dnf install command expands to include bat and fd-find as packages and is reformatted across multiple lines. Architecture-dependent blocks that downloaded and extracted ripgrep, bat, and fd from upstream releases are removed entirely. Container default CMD is set to ["tail", "-f", "/dev/null"].

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 CLI tools once scattered far and wide,
Now bundled in packages, side by side!
No more tar-archive acrobatics to perform,
Just dnf install keeps the images warm. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'base: Use bat, fd, rg from dnf repos' directly and accurately summarizes the main change: switching from GitHub release downloads to dnf repository packages for bat, fd, and ripgrep.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svor svor Awaiting requested review from svor svor is a code owner
@SDawley SDawley Awaiting requested review from SDawley SDawley is a code owner
@dkwon17 dkwon17 Awaiting requested review from dkwon17 dkwon17 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jnohlgard