{{ message }}
feat: podman kubedock enhancement#224
Open
eye0fra wants to merge 2 commits into
Open
Conversation
d1d387a to
215229b
Compare
d5f43be to
03efdad
Compare
Member
Author
|
You're right I will push the permission fix |
d21b40a to
913d24b
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eye0fra The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
Signed-off-by: Mattia Mascia <mattiam7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR introduces significant enhancements to the Podman/Kubedock integration within the UBI9 base image, focusing on improved compatibility, usability, and automation for containerized workflows that rely on Podman, especially in environments where Kubedock is enabled.
Key Changes
1. Podman Wrapper System Overhaul
New Wrapper Scripts:
podman-compose-down-wrapper.sh:Provides a robust replacement for
podman compose down(ordocker compose down) to ensure proper cleanup of containers/services, especially when running with Kubedock where standard compose down cannot directly shut down pods.podman-interactive-wrapper.sh:Transparently intercepts problematic
podman run -it ...invocations and replaces them with a workaround usingpodman exec, ensuring interactive sessions work reliably with Kubedock.The wrapper forcibly replaces any
--useror-uoptions with the current user's numeric UID (viaid -u), ensuring the container always runs as the invoking OpenShift user id, regardless of what is passed on the command line.docker.sh:Emulates the Docker CLI using Podman, with logic to route commands through the appropriate wrapper when Kubedock is enabled.
Enhanced
podman-wrapper.sh:compose downand interactiveruncommands to the new specialized wrappers.2. Dockerfile Updates
/usr/bin/dockerand all wrappers are properly installed and owned.3. Kubedock Setup Improvements
kubedock_setup.shnow:KUBEDOCK_PARAMSbased on available environment variables (REQUEST_CPU,REQUEST_MEMORY,REAPER_KEEPMAX), allowing for more flexible resource and lifecycle management.Testing
podman run -it ...)Backward Compatibility