feat: add publicPath options by QingWei-Li · Pull Request #52 · developit/workerize-loader · GitHub
Skip to content

feat: add publicPath options#52

Merged
developit merged 3 commits intodevelopit:masterfrom
QingWei-Li:patch-1
Jun 16, 2020
Merged

feat: add publicPath options#52
developit merged 3 commits intodevelopit:masterfrom
QingWei-Li:patch-1

Conversation

@QingWei-Li
Copy link
Copy Markdown
Contributor

Comment thread src/index.js Outdated
Co-Authored-By: Jason Miller <developit@users.noreply.github.com>
@xzilja
Copy link
Copy Markdown

xzilja commented Dec 7, 2019

@Poky85
Copy link
Copy Markdown

Poky85 commented Jan 19, 2020

Tested and confirm that publicPath option allows Next.js integration with following next.config.js:

module.exports =  {
  webpack: (config, params) => {
    config.module.rules.push({
      test: /\.worker\.(js|ts)$/,
      loader: 'workerize-loader',
      options: {
        name: 'static/[hash]',
        publicPath: '/_next/'
      },
    });
    config.output.globalObject = 'self';

    return config
  }
};

@developit
Copy link
Copy Markdown
Owner

Apologies for the super slow merge here! I'm fixing the CI, you're right about it being totally unrelated.

@xzilja
Copy link
Copy Markdown

xzilja commented Mar 4, 2020

@QingWei-Li any chance you could merge this please?

@QingWei-Li
Copy link
Copy Markdown
Contributor Author

@iljadaderko I'm not a maintainer. We need @developit to merge.

@mrdivyansh
Copy link
Copy Markdown

@developit any chance you could merge this please?

@developit developit merged commit 86cd7c0 into developit:master Jun 16, 2020
@developit
Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants