fix: Incorrect transform with async/await (#565) by PeterBurner · Pull Request #968 · developit/microbundle · GitHub
Skip to content

fix: Incorrect transform with async/await (#565)#968

Merged
rschristian merged 3 commits intodevelopit:masterfrom
PeterBurner:master
Jun 4, 2022
Merged

fix: Incorrect transform with async/await (#565)#968
rschristian merged 3 commits intodevelopit:masterfrom
PeterBurner:master

Conversation

@PeterBurner
Copy link
Copy Markdown
Contributor

@PeterBurner PeterBurner commented Jun 3, 2022

@PeterBurner
fix: Incorrect transform with async/await (developit#565)
0a9640a 
* Update babel-plugin-transform-async-to-promises to v0.8.18
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 3, 2022 •
edited
Loading

rschristian
rschristian approved these changes Jun 3, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rschristian rschristian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Any idea if this is necessary? Looks like Yarn (v1, anyhow) will correctly resolve the newer version on a fresh install. Not sure if other tools do the same.

Edit: Looks like the snapshots need to be updated. Looks to be a pretty minor & innocent diff, so jest -u should be fine

@rschristian rschristian merged commit 88241dd into developit:master Jun 4, 2022
@preact-bot preact-bot mentioned this pull request Jun 4, 2022
Merged
@PeterBurner
Copy link
Copy Markdown
Contributor Author

PeterBurner commented Jun 4, 2022

Any idea if this is necessary? Looks like Yarn (v1, anyhow) will correctly resolve the newer version on a fresh install. Not sure if other tools do the same.

This might be true. However since the fixed bug in babel-plugin-transform-async-to-promises affects how code is transformed, an update might break things for some users. In my eyes this warrants a new microbundle version. Including a explicit warning in the release notes.

@rschristian
Copy link
Copy Markdown
Collaborator

rschristian commented Jun 4, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschristian rschristian rschristian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect transform with async/await

2 participants

@PeterBurner @rschristian