{{ message }}
fix: Extra CSS files generated#777
Merged
developit merged 4 commits intodevelopit:masterfrom May 27, 2021
rschristian:fix/cssFileGen
Merged
fix: Extra CSS files generated#777developit merged 4 commits intodevelopit:masterfrom rschristian:fix/cssFileGen
developit merged 4 commits intodevelopit:masterfrom
rschristian:fix/cssFileGen
Conversation
Owner
|
Seems reasonable to me - this doesn't create any incorrect references to the CSS files right? I don't think we provide a way to get the filename so my guess is that it's fine. |
developit
approved these changes
Jan 6, 2021
Collaborator
Author
developit
approved these changes
May 27, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #776
Description
A bug with #769 meant that for each JS file output format (excluding UMD) a matching CSS file would be generated, i.e.,
index.modern.cssandindex.module.css(not a CSS module).I corrected this by restoring the old logic used, which was relying on
writeMeta.