{{ message }}
Repository navigation
refactor: updates to advanced rag agent - #3934
Merged
Merged
Conversation
github-actions
Bot
added
integration:agent-pack
type:documentation
Contributor
sjrl
commented
Sep 9, 2026
Comment on lines
143
to
149
| tools: list[Tool | Toolset] = [ | ||
| DocumentStoreToolset(document_store, max_fetched_docs=max_fetched_docs), | ||
| ListMetadataFieldsTool(document_store), | ||
| GetMetadataFieldValuesTool(document_store), | ||
| GetMetadataFieldRangeTool(document_store), | ||
| FetchDocumentsByFilterTool(document_store, max_docs=max_fetched_docs), | ||
| retrieval_tool, | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
The store tools are listed individually rather than bundled in a DocumentStoreToolset, so that each tool is present in the yaml config: its name, its description, and its own limits are then reachable, and a tool can be dropped by removing one entry.
sjrl
commented
Sep 9, 2026
Comment on lines
+90
to
+92
Contributor
Author
There was a problem hiding this comment.
Add internal tracing support for tracking token usage of the chat generator run inside the back up answer hook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Contains just the changes to the existing advanced rag agent that I made while working on the harness optimization agent. These changes expose more of the advanced rag agent's configuration in the yaml file which I'm using as the reference for the optimizer agent to make changes to.
These changes expose more settings like the tools and their descriptions in the yaml file and add tracing support to the backup answer hook.
How did you test it?
New and existing tests.
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.