{{ message }}
Repository navigation
feat: Updates to make Haystack compatible with python 3.14 - #10634
Merged
Merged
Conversation
Contributor
github-actions
Bot
added
topic:tests
topic:build/distribution
topic:core
type:documentation
sjrl
changed the title
Collaborator
Pull Request Test Coverage Report for Build 23136127991Details
💛 - Coveralls |
Member
|
@sjrl Out of curiosity I tried Haystack with Python 3.14 and found two additional issues to address:
|
Contributor
Author
Hey @julian-risch any idea how these errors popped up for you? I ran all unit and integration tests using our CI with python 3.14.3 and they passed except for the two I mentioned in our e2e tests. So just curious how you identified the additional issues. |
Contributor
Author
|
@julian-risch made the changes! Would appreciate another review when you have the time. |
sjrl
commented
Mar 16, 2026
|
|
||
|
|
||
| @pytest.mark.parametrize("batch_size", [1, 3]) | ||
| @skip_spacy |
Contributor
Author
There was a problem hiding this comment.
@julian-risch I was able to update your code to only skip the spacy test. Also required a change in the pyproject.toml in the e2e test env
Member
Closed
alvinttang
pushed a commit
to alvinttang/haystack
that referenced
this pull request
Mar 18, 2026
…i#10634) * start adding python 3.14 support in tests * start updating tests * Add reno * Updates * Collect tests that should be skipped in python 3.14+ * run tests using python 3.14 * Revert back to 3.10 for testing * Fix flaky tests * Skip only spacy tests if python 3.14+ * switch to get_running_loop
julian-risch
added a commit
that referenced
this pull request
Oct 10, 2026
Pipeline.run_async writes each sync component's outputs when its thread finishes, so variadic inputs arrive in completion order. Six scenarios assumed the sync order; CI on Python 3.15 hit three of them on every run. Follows the AnyOrder approach of the Python 3.14 PR (#10634). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Collect tests that should be skipped when using python 3.14+. These tests should eventually be removed when the min version of python becomes 3.14.
Made some minor adjustments to type checking when handling bare Union types. Previously we were relying on
get_origin(typing.Union)to returnNone. Starting in python 3.14get_origin(typing.Union)now returnstyping.Unionso I added specific checks for handling bare Union types.How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.