Fix AttributeError in ABACUS Gamma post-processing (self.addfix -> self.add_fix) by Sreekant13 · Pull Request #1920 · deepmodeling/dpgen · GitHub
Skip to content

Fix AttributeError in ABACUS Gamma post-processing (self.addfix -> self.add_fix)#1920

Merged
njzjz merged 1 commit into
deepmodeling:masterfrom
Sreekant13:fix/gamma-add-fix-attribute-typo
Jul 2, 2026
Merged

Fix AttributeError in ABACUS Gamma post-processing (self.addfix -> self.add_fix)#1920
njzjz merged 1 commit into
deepmodeling:masterfrom
Sreekant13:fix/gamma-add-fix-attribute-typo

Conversation

@Sreekant13

@Sreekant13 Sreekant13 commented Jun 30, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Fixes #1900.

Gamma.__stru_fix referenced self.addfix, but the attribute is self.add_fix (set in __init__). This raised an AttributeError whenever add_fix was enabled during ABACUS Gamma post-processing. Corrected the spelling to match.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue in Abaqus post-processing where structure-fix handling could fail due to an incorrect setting reference.
    • Improved stability for runs that use fix-point adjustments.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 49.80%. Comparing base (7af5246) to head (8fd2b8f).

Files with missing lines Patch % Lines
dpgen/auto_test/Gamma.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1920   +/-   ##
=======================================
  Coverage   49.80%   49.80%           
=======================================
  Files          83       83           
  Lines       14986    14986           
=======================================
  Hits         7464     7464           
  Misses       7522     7522

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@njzjz njzjz requested a review from pxlxingliang July 1, 2026 02:32
@Sreekant13 Sreekant13 requested a review from pxlxingliang July 2, 2026 02:58
@njzjz njzjz merged commit 932afac into deepmodeling:master Jul 2, 2026
8 checks passed
@Sreekant13

Sreekant13 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pxlxingliang pxlxingliang Awaiting requested review from pxlxingliang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Code scan] Fix ABACUS Gamma add_fix attribute typo

3 participants

@Sreekant13 @pxlxingliang @njzjz