{{ message }}
Repository navigation
A document that states no date is not asked for one - #998
Merged
Merged
Conversation
0064 decision 1 says the separate call that read a date off the opening goes away. Cut 2 kept it as a fallback for documents where extraction reported no entry. With usage labelled by call (#996), twenty Re-DocRED documents: sixteen took the fallback, each asking the question extraction had just answered with "none" and getting the same answer, about 940 tokens a document. On the time bench every document that states a date had it reported by extraction; the fallback never found one that was missed. The resolver no longer calls the model for the document's date. A document whose extraction reported none has none: a relative expression in it waits at grade C and its statements carry no attestation. A date stored by the old call on a document extracted before cut 2 is still read. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Wayland Yang <wayland0916@gmail.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Wayland Yang <wayland0916@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

0064 decision 1 says the separate call that read a date off the opening goes away. Cut 2 (#991) kept it as a fallback for documents where extraction reported no entry, which I did not make plain enough at the time.
With usage labelled by call (#996), on twenty Re-DocRED documents: sixteen took the fallback, each asking the question extraction had just answered with "none" and getting the same answer, about 940 tokens a document (2.3% of the total). On the time bench every document that states a date had it reported by extraction; the fallback never found one that was missed.
The resolver no longer calls the model for the document's date. A document whose extraction reported none has none: a relative expression in it waits at grade C and its statements carry no attestation. A date stored by the old call on a document extracted before cut 2 is still read.
Test:
a_document_that_states_no_date_is_not_asked_for_one(scripted model: two requests, neither the dating prompt; the time word at grade C; no attestation).🤖 Generated with Claude Code