{{ message }}
Repository navigation
Report rule read failures as tool errors - #733
Merged
Merged
Conversation
Signed-off-by: mayakid <29959320+mayakid@users.noreply.github.com>
Contributor
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

When database reads fail,
list_rulesandrule_matchesalready return failure text, but theirToolResultdefaults to success. MCP therefore returnsisError: falsebeside "Could not read the rules." or "Could not read what that rule marks." Clients that inspect the flag cannot distinguish those failures from successful reads.Mark just the two database-error branches with
.error(). Extend the existing failed-read regression with both tools, and add authenticated MCP coverage for normal rule listings, matches, and successful empty results. Response text and successful-read behavior stay the same. The existing PostgreSQL CI job already runs this MCP suite.Validation:
isError: falseforlist_rules.UTOPIA_TEST_REQUIRE_DB=1; both failed-read branches are covered.