{{ message }}
Repository navigation
Conversation
Signed-off-by: Virtue039 <virtue039@qq.com>
This was referenced Oct 19, 2026
…azy fact counts Signed-off-by: Virtue039 <virtue039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Two exact namesakes can attach to the person with the stronger passage/profile similarity even when a source-grounded statement uniquely identifies the other person. Check the current subject's valid quotes before profile tiers, while retaining the existing fallback and review lifecycle.
Current head:
6b63f5919b40274d59bc61e4a0e242f57187e7ef, including latest devf2e2a47a2b6d0508aab88dc1b3689a6fee44c606(rechecked 2026-10-21). Merge conflict resolved; remains draft because incomplete asynchronous counterfactuals still limit regression attribution. This PR does not claim a stable overall accuracy gain.Change
No API, schema, extraction prompt, adjudicator, unresolved-entity pool or merge gate changes. Three files, +397/-19 lines. #1192/#1199 remain closed without merging; this change does not revive them. The negative-example implementation in #1334 is independent.
Validation at this head
All 40 fixed checks pass, including the original eight unchanged inputs/gold and #1220's adjudicator-input controls. Current dev still reproduces the original two passage-over-profile failures. Forward/reverse controls cover correct ownership, one candidate, unrelated co-occurrence, quote ownership/grounding, shared/conflicting clues, typed/untyped and incompatible candidates, caller exclusions, absent-evidence fallback and repeated mentions without extra entities/reviews. The two known-failure entries are removed. Removing stored-spelling compatibility makes the new Markdown check fail in both orders; the final restored implementation passes.
fmt, workspace/all-targets clippy (
-D warnings), full workspace tests (1,645 passed, 0 failed, 6 pre-existing ignored), workspace build, frozen pnpm install/build, 308 web tests and 15 scorer tests pass. DB/PDF require guards were enabled. CI 39535994426 passed all six jobs at the exact head. Separate baseline/candidate artifacts were rebuilt from the frozen commits; hashes are recorded. Dependency caches were reused; these were not empty-cache builds.Fresh same-session live-model comparison
2026-10-21: unchanged repository identity corpus/scorer;
qwen3.7-flash-2026-07-15, thinking disabled; pinned BGE-M35617a9f61b028005a4858fdac845db406aefb181, CPU float32 normalized CLS, 1024 dimensions, max 8192 tokens. Two rounds, each two independent forward/reverse runs per side: 8 new measured KBs per side, 16 total. Interleaved sides in one session, round barriers, one active KB per side, serial documents. Registration's empty default KB is excluded. No score-selected reruns.All 192 documents completed, with zero provider failures, unfinished documents or bad jobs. All 1,023 responses reported the requested model version. The preflight's 17 tokens are excluded. Model request options match per call mode: streamed calls use temperature 0 and max_tokens 65536; non-streamed calls retain repository/provider defaults. Both disable thinking. Local embedding request/token fields are not mixed into chat token totals.
F1 is computed on found anchors, so pair errors must be read with coverage. Both new rounds have slightly higher F1, but splits/entities increase and the historical frozen revision's measurement moved in the opposite direction. These small samples do not establish a stable overall gain. The recorded live named-entity decisions also do not demonstrate a direct benefit from the patch; the deterministic controls establish the targeted fix.
All 16 KBs: score, coverage, missing anchors and work
F/R = forward/reverse. Human counts sum the original scorer's pending
humanrows, not review groups.Regression attribution
For the older frozen
70bf7a7/c019e4cmeasurement, the previous full-tape controls reproduced 22/27 candidate-extra entries on the old baseline. Follow-up now reproduces three more at their first-error document boundaries with identical recorded requests/replies and all score fields. The last two resolver transitions also return identical choices, review proposals and original scores on restored pre-decision state (including original name-vector ownership); these isolate the resolver and do not pretend the two full asynchronous tapes completed. An initial restoration with incorrectly repointed name vectors is retained as an invalid attempt, not final evidence.For the fresh
f2e2a47/6b63f59measurement, inspect all 25 candidate-extra entries: 4 merges, 13 splits, 8 missing anchors. Ten pair entries involve an anchor absent on the paired baseline and are coverage exposure, not directly comparable new pair errors. Source replies expose omitted subjects, conflated same-name subjects, described-person flags, alias declarations and unclassified English equipment. A reverse d04 merge is located in the subsequent adjudicator investigation choosing same (0.95). These observations do not classify everything as model noise.Atomic pre-request identity snapshots reproduce all 16 final stock-scorer results exactly and locate 176 settled document prefixes. All 96 candidate document named-entity phases, not a score-selected subset, are replayed on the same captured candidate state/reply/vectors using both commits: 0 differing choices, profiles, name facts, review candidates or flags. The actual parser/store resolver and hashed caller-cache helpers participate. Downstream statement/name application, type alignment, adjudication and scheduling are outside that isolated control.
Additional complete-pipeline strict replays use the original 511 candidate replies and fixed embedding cache, map only dynamic UUIDs, and refuse unmatched inputs. They make zero provider calls and are kept separate from valid live measurements.
Complete diagnostic replays: 6; new entries reproduced on the baseline at the first-error boundary: 17/25. Incomplete replays remain incomplete; no mismatched input receives a substitute reply.
All five incomplete tape groups stop at the same first unmatched request on both commits (after UUID mapping). In each, the recorded investigation
factsresult contains both负责 → 海探1and批复了 → 海探1, while the replay contains only the latter. This locates a tool-visible-fact reproducibility limit; it does not establish universal downstream equivalence. Nearest-text comparison is diagnostic only and never supplies a completion.Eight entries remain beyond the validated strict replay prefixes; each still has an identical fixed-state named-phase control:
For r2-b1 forward, both replay graphs agree with each other and match the primary's entities/profiles, reviews, scores and active facts; each also contains one additional already-invalidated typed
leadsfact. The original graph comparison remains False in the table; historical facts were not filtered to make it pass.The graph projection compares entity names/classes/descriptions/profiles, facts including invalidation flags, and review outcomes after normalizing creation IDs; it is not a byte-identical database claim. All attempts, raw model replies, identity states, per-KB metrics/missing anchors, first-error notes, scripts, binary/source hashes and validation logs are retained in the local evidence bundle. Credentials, account/settings rows, private keys and model weights are excluded.
Remaining: unmatched asynchronous adjudication/evidence inputs prevent a complete whole-pipeline equivalence claim. The fixed-state tests found no directly attributable new named-entity regression, but this narrower result cannot exclude every downstream scheduling effect. The next diagnostic needs a transaction-consistent capture at the
factstool read and its task boundary, not just the later model-request snapshot. Keep draft while that boundary is made reproducible; do not expand this PR into extraction/alias/adjudicator lifecycle work or claim overall accuracy improvement. No further model configuration is needed from the user.Refs #1136, #1202, #1220.