{{ message }}
Repository navigation
Six tests that prove again what their change left alone are removed - #1127
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Wayland Yang <wayland0916@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A test should cover the behaviour its change introduced. These six prove again something the change did not touch, or prove the same thing a second time at another layer. They cost review time and CI time and guard nothing of their own. The measure is the one stated on #1126.
What changes
343 lines of tests removed, no code change:
notion_resync_tests.rs(one test, whole file)ingest_item's behaviour and not Notion's. What Notion's fetch returns after a failed read is held bya_page_whose_body_cannot_be_read_is_left_out_and_the_others_still_come_back.flat_page_markdown_is_unchangedchild_request_error_keeps_existing_diagnosticschild_rate_limit_exhaustion_is_an_errorPaced::send's behaviour. That nested requests share the pacing stays covered.date_detection_keeps_upload_access_and_folder_checksunrecognized_literal_text_keeps_the_existing_fallbackA fixture field only the removed upload test read goes with it.
Looked at and kept: the other tests from the same PRs (about 75), each of which holds a behaviour its change introduced.
How it was checked
cargo clippy -p utopia-server --all-targets -- -D warningsis clean, and thenotion,documents_routesandrdftest groups pass with the database required (17, 14 and 33 tests).🤖 Generated with Claude Code